Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added multipart envelope support #59

Closed
wants to merge 1 commit into from

Conversation

timdonegan
Copy link

More complicated zeromq patterns require the more complex "envelopes": http://zguide.zeromq.org/page:all#The-Extended-Reply-Envelope

@ggggggggg
Copy link
Contributor

send_multipart + recv_multipart are clearly matched, while send vs recv_multipart are not. Also this is how pyzmq does it, which is a small plus. Regardless of the name for send, the functionality is useful.

@ggggggggg
Copy link
Contributor

Actually it would probably be better to define send_multipart(socket::Socket, parts::AbstractArray) or send_multipart(socket::Socket, parts::AbstractArray{String}).

@JamesWrigley
Copy link
Member

@timdonegan, if you're still interested in this would you have time to rebase and finish it? Otherwise I'm happy to give it a shot. My apologies for taking a literal decade to respond 😳

@alexisvrignaud
Copy link

I would be interested in the implementation of the receive_multipart! That's very useful!

@JamesWrigley
Copy link
Member

May I nerd-snipe you into finishing it? 😉 I think the implementation in this PR looks good, the only things you'd have to do are:

  • Change send_multipart()'s signature to send_multipart(socket::Socket, parts::AbstractVector). We can rely on dispatch to do the right thing.
  • Add docstrings and tests for the new functions.

@JamesWrigley
Copy link
Member

Closing in favour of #253.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants